feat: add consistent ban reason for sync #5729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added consistent ban reason for sync/block_sync sync/header_sync and sync/horizon_state_sync w.r.t. validation errors. `ValidationError::get_ban_reason` will determine if a particular validation error is ban-able.
hansieodendaal
changed the title
ghpbot-tari-project
added
P-acks_required
sdbondi
approved these changes
Sep 3, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
Sep 3, 2023
SWvheerden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added consistent ban reason for sync/block_sync sync/header_sync and sync/horizon_state_sync w.r.t. validation errors.
Motivation and Context
ValidationError::get_ban_reasonwill determine if a particular validation error is ban-able.How Has This Been Tested?
Pass existing tests
What process can a PR reviewer use to test or verify this change?
Code walk-through
Breaking Changes