Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: add one-sided coinbase payments - approach 1 #5937

Conversation

hansieodendaal
Copy link
Contributor

Description

Added one-sided and stealth coinbase transactions. Coinbases can now only be paid to a nominated wallet address other than self.

Motivation and Context

This will enable mining to be done to a cold wallet, where the wallet used for mining cannot receive any coinbases.

How Has This Been Tested?

TBD

What process can a PR reviewer use to test or verify this change?

TBD

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

BREAKING CHANGE: Coinbases can now only be paid to a nominated wallet address other than self.

Copy link

github-actions bot commented Nov 10, 2023

Test Results (CI)

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 11d089d.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 10, 2023
@hansieodendaal hansieodendaal changed the title [wip] feat: add one-sided coinbase payments [wip] feat: add one-sided coinbase payments - approach 1 Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

Test Results (Integration tests)

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 11d089d.

♻️ This comment has been updated with latest results.

Added one-sided and stealth coinbase transactions. Coinbases can now only be paid to a
nominated wallet address other than self.
@hansieodendaal
Copy link
Contributor Author

Closed in favour of #5967

@hansieodendaal hansieodendaal deleted the ho_one_sided_coinbase branch November 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants