feat: enable revealed-value proofs #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled revealed-value proofs for all output types, which are be controlled via the consensus constants. Range proof types are mapped to output types.
ghpbot-tari-project
added
P-acks_required
hansieodendaal
commented
Nov 23, 2023
Test Results (Integration tests) 2 files + 2 11 suites +11 55m 15s ⏱️ + 55m 15s For more details on these failures, see this check. Results for commit ee25d1e. ± Comparison against base commit 89b19f6. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
the
CR-too_long
SWvheerden
reviewed
Nov 24, 2023
SWvheerden
approved these changes
Nov 27, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled revealed-value proofs for all output types, which are be controlled via the consensus constants. Range-proof types are mapped to output types.
From the merge mining proxy/miner log, coinbase output showing
range_proof_type: RevealedValueandProof: None:Note: The faucets changed due to
RangeProofTypenow being parsed with snake case -"range_proof_type":"RevealedValue"changed to"range_proof_type":"revealed_value"on every output line.Motivation and Context
See #5968
How Has This Been Tested?
Added unit tests
Unit tests pass
Cucumber tests pass
System-level tests
[TO BE COMPLETED]What process can a PR reviewer use to test or verify this change?
Code walkthrough
Review the additional unit tests
Run system-level tests
Breaking Changes