-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make base node support 1 click mining #6019
feat: make base node support 1 click mining #6019
Conversation
1 click bn ready miner
8f2fc0c
to
8400e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended, nice.
Some comments below.
######################################################################################################################## | ||
# # | ||
# Base Node Configuration Options (BaseNodeConfig) # | ||
# # | ||
######################################################################################################################## | ||
|
||
# If you are not running a Minotari Base node, you can simply leave everything in this section commented out. Base nodes | ||
# help maintain the security of the Minotari token and are the surest way to preserve your privacy and be 100% sure that | ||
# no-one is cheating you out of your money. | ||
|
||
[dibbler.base_node] | ||
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json") | ||
identity_file = "config/base_node_id_dibbler.json" | ||
|
||
[igor.base_node] | ||
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json") | ||
identity_file = "config/base_node_id_igor.json" | ||
|
||
[esmeralda.base_node] | ||
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json") | ||
identity_file = "config/base_node_id_esmeralda.json" | ||
|
||
[stagenet.base_node] | ||
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json") | ||
identity_file = "config/base_node_id_stagenet.json" | ||
|
||
[nextnet.base_node] | ||
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json") | ||
identity_file = "config/base_node_id_nextnet.json" | ||
|
||
[base_node] | ||
# Set to false to disable the base node GRPC server (default = true) | ||
#grpc_enabled = true | ||
|
||
# The socket to expose for the gRPC base node server (default = "/ip4/127.0.0.1/tcp/18142") | ||
#grpc_address = "/ip4/127.0.0.1/tcp/18142" | ||
|
||
# gRPC authentication method (default = "none") | ||
#grpc_authentication = { username = "admin", password = "xxxx" } | ||
|
||
# Use gRPC over TLS (default = false) | ||
#grpc_tls_enabled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SWvheerden this is now duplicated in b_peer_seeds.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #6029
Description
On startup make the basenode ask you if you want to run mining or not.
Add a flag
--enable-mining
Fix base node flag
--enable-grpc
Motivation and Context
This will make it easier to mine from a 1-click perspective where a new miner does not need to edit confiles in order to mine
How Has This Been Tested?
manual