-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: console wallet use dns seeds #6034
feat: console wallet use dns seeds #6034
Conversation
Nice find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I want to test this.
but a clarification if you will:
should use the DNS seed, and not just the seeds in the config file
and not just
So it should use both? Because the change swings the pendulum, to ignore the config seeds, and use whatever the PeerDB already has.
At what point did it fetch DNS seeds?
it should use both: tari/base_layer/p2p/src/initialization.rs Line 583 in 851cb00
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the response.
Tested locally:
Created new wallet on esme network. Removed the peers from the config. Deleted the dht, and peer db. Restarted the wallet and it started finding peers instantly, found and connected to a base node, and carried on.
👍🏻
Ack (sans ut)
Description
Console wallet use dns seeds
Motivation and Context
The console wallet should use the DNS seed, and not just the seeds in the config file
How Has This Been Tested?
Manual