feat: side load chat #6042
Merged
feat: side load chat #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
chat-ffi-sideload
branch
from
9d91355 to
7f8f16b
Compare
brianp
force-pushed
the
chat-ffi-sideload
branch
from
7653c11 to
50e4a55
Compare
SWvheerden
approved these changes
Dec 14, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chat, and the Chat FFI were designed to operate as an independent functioning node on the network. It brings up it's own p2p and comms stack, and has it's own identity.
This is great but wallets like Aurora already have this functionality, and currently to run chat it operates two entire stacks. In the case of having a wallet already we don't need to run two entire stacks. We can utilize the wallet resources and sideload chat from an existing node.
Motivation and Context
Share resources, lower memory usage, increase network stability, make chat easier to utilize within Aurora.
How Has This Been Tested?
CI
What process can a PR reviewer use to test or verify this change?
Inspect the FFI changes for proper error handling and returns.
Breaking Changes