chore(ci): fix s3 uploads for none tagged builds #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
stringhandler
approved these changes
Dec 21, 2023
ghpbot-tari-project
removed
the
P-reviews_required
stringhandler
merged commit a3b65d5
into
tari-project:development
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
S3 upload job needs testNet location, but this is only added for tagged releases. Setting a default as testnet.
Motivation and Context
Fix
line 11: 44746 Segmentation fault: 11error in the s3 upload job.How Has This Been Tested?
Not checked.
What process can a PR reviewer use to test or verify this change?
Check there are no errors in the s3 upload job and also check that assets are upload into the s3 bucket.
Breaking Changes