chore(ci): fix windows envs with bash shell for s3 uploads #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
approved these changes
Jan 2, 2024
ghpbot-tari-project
added
the
P-acks_required
Test Results (CI)1 264 tests 1 263 ✅ 13m 28s ⏱️ For more details on these failures, see this check. Results for commit 5201354. |
|
sdbondi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the bash shell to update GitHub Action Workflows envs for later use in S3 upload step.
Motivation and Context
Finally find out why env not updating for Windows workflows, seems that we need to use the bash shell to make changes.
How Has This Been Tested?
Run workflows in test branch from the repo
What process can a PR reviewer use to test or verify this change?
Check the s3 upload on Windows for any errors.
Breaking Changes