chore: add script to manage crates.io owners #6112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many packages in the tari codebase. To prevent squatting and possible domain hijacking attacks, we need to register these on crates.io (they don't have namespacing :( ) Managing the owners of these crates on crates.io is a manual nightmare, so this script can automate it for you. This commit introduces significant refinements to the owner management script update_owners.sh. The script now iterates over packages, lists current owners, and compares them with expected owners. It includes functions to add, remove, and verify owners based on the comparison. Packages with the group 'ignore' are skipped during the iteration.
ghpbot-tari-project
added
P-acks_required
Changes to the crates.io ownership script and pgp key list require a lead maintainer approval.
Test Results (CI)1 268 tests 1 268 ✅ 11m 43s ⏱️ Results for commit ecb63b6. ♻️ This comment has been updated with latest results. |
Adding `-c` to cli arguments only checks the current/expected owner list.
Adds the remainder of the DAN crates to the DAN group
Test Results (Integration tests)29 tests 29 ✅ 11m 46s ⏱️ Results for commit ecb63b6. ♻️ This comment has been updated with latest results. |
Adds sleep after cargo registry calls so that we don't have to wait for things that don't affect rate limits.
SWvheerden
approved these changes
Feb 1, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many packages in the tari codebase. To prevent squatting and possible domain hijacking attacks, we need to register these on crates.io (they don't have namespacing :( )
Managing the owners of these crates on crates.io is a manual nightmare, so this script can automate it for you.
This commit introduces significant refinements to the owner management script update_owners.sh.
The script now iterates over packages, lists current owners, and compares them with expected owners.
It includes functions to add, remove, and verify owners based on the comparison. Packages with the group 'ignore' are skipped during the iteration.
Breaking Changes