Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet add restart validation to start #6113

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds back the restart tx protocols on wallet start

Motivation and Context

The wallet should restart its transactions protocols on start

@SWvheerden SWvheerden requested a review from a team as a code owner January 31, 2024 15:22
Copy link

github-actions bot commented Jan 31, 2024

Test Results (CI)

1 268 tests   1 268 ✅  11m 2s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 5e673c1.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   14m 27s ⏱️ + 14m 27s
29 tests +29  28 ✅ +28  0 💤 ±0  1 ❌ +1 
30 runs  +30  29 ✅ +29  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 5e673c1. ± Comparison against base commit b6b80f6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Spoke with SW offline about adding this back in, as it was once removed. Validated it should have been put back and not left out.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 2, 2024
@SWvheerden SWvheerden merged commit 5c236ce into tari-project:development Feb 2, 2024
12 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_add_validation_trigger branch February 2, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants