Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet ffi use dns #6152

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Add the option for the wallet_ffi, to use the DNS build into it.

Motivation and Context

Allow the fii to use DNS.

How Has This Been Tested?

Manual

Copy link

github-actions bot commented Feb 16, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   21m 11s ⏱️ + 21m 11s
29 tests +29  28 ✅ +28  0 💤 ±0  1 ❌ +1 
30 runs  +30  29 ✅ +29  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 1235f11. ± Comparison against base commit 19a824d.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

Test Results (CI)

    3 files    117 suites   42m 12s ⏱️
1 263 tests 1 263 ✅ 0 💤 0 ❌
3 781 runs  3 781 ✅ 0 💤 0 ❌

Results for commit 03192e1.

♻️ This comment has been updated with latest results.

brianp
brianp previously approved these changes Mar 1, 2024
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miner change could reduce overall changes and interface if we interpolate the DNS address based on the network instead of passing it in.

Also a note about dnssec, but if it's been tested #yolo.

base_layer/wallet_ffi/src/lib.rs Show resolved Hide resolved
base_layer/wallet_ffi/src/lib.rs Show resolved Hide resolved
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
@ghpbot-tari-project ghpbot-tari-project removed P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 1, 2024
make address option in set _address
@SWvheerden SWvheerden requested a review from a team as a code owner March 4, 2024 10:38
@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 4, 2024
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 4, 2024
@SWvheerden SWvheerden merged commit 464f2c3 into tari-project:development Mar 4, 2024
13 of 15 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Mar 5, 2024
* development:
  feat: make the make_it_rain submission rate a float (tari-project#6180)
  feat: wallet ffi use dns (tari-project#6152)
  chore: add localnet gen block (tari-project#6176)
  fix: hide unmined coinbase (tari-project#6159)
  chore: removes panics from wallet burn task (tari-project#6163)
  test: fix cucumber network environment (tari-project#6175)
  feat: lazily evaluate for new random_x template (tari-project#6170)
@SWvheerden SWvheerden deleted the sw_ffi_usedns branch March 5, 2024 06:35
brianp added a commit to brianp/tari that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants