-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wallet ffi use dns #6152
feat: wallet ffi use dns #6152
Conversation
Test Results (Integration tests) 2 files + 2 11 suites +11 21m 11s ⏱️ + 21m 11s For more details on these failures, see this check. Results for commit 1235f11. ± Comparison against base commit 19a824d. ♻️ This comment has been updated with latest results. |
Test Results (CI) 3 files 117 suites 42m 12s ⏱️ Results for commit 03192e1. ♻️ This comment has been updated with latest results. |
fc39790
to
23eef4b
Compare
518ade9
to
1235f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miner change could reduce overall changes and interface if we interpolate the DNS address based on the network instead of passing it in.
Also a note about dnssec, but if it's been tested #yolo.
make address option in set _address
* development: feat: make the make_it_rain submission rate a float (tari-project#6180) feat: wallet ffi use dns (tari-project#6152) chore: add localnet gen block (tari-project#6176) fix: hide unmined coinbase (tari-project#6159) chore: removes panics from wallet burn task (tari-project#6163) test: fix cucumber network environment (tari-project#6175) feat: lazily evaluate for new random_x template (tari-project#6170)
This reverts commit 464f2c3.
Description
Add the option for the wallet_ffi, to use the DNS build into it.
Motivation and Context
Allow the fii to use DNS.
How Has This Been Tested?
Manual