Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: console wallet recovery improvements for ledger #6455

Merged

don't show seed words when recovering from hardware wallets

e739ac3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: console wallet recovery improvements for ledger #6455

don't show seed words when recovering from hardware wallets
e739ac3
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Integration tests) failed Aug 6, 2024 in 0s

1 parse errors, 2 fail, 17 pass in 13m 47s

 2 files   1 errors  9 suites   13m 47s ⏱️
19 tests 17 ✅ 0 💤 2 ❌
21 runs  19 ✅ 0 💤 2 ❌

Results for commit e739ac3.

Annotations

Check failure on line 0 in artifacts/junit-ffi-cucumber/cucumber-output-junit.xml

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

Error processing result file

File is empty.
Raw output
artifacts/junit-ffi-cucumber/cucumber-output-junit.xml

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

1 out of 2 runs failed: Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3

artifacts/junit-cucumber/cucumber-output-junit.xml [took 2m 23s]
Raw output
Step panicked. Captured output: Burn transaction has status 0 when we desired 1 (TRANSACTION_STATUS_BROADCAST), 2 (TRANSACTION_STATUS_UNCONFIRMED), or 6 (TRANSACTION_STATUS_CONFIRMED)
  Scenario: Simple reorg with burned output
   ✔  Given I have a seed node SEED_B
   ✔  When I have a base node B connected to seed SEED_B
   ✔  When I have wallet WB connected to base node B
   ✔  When I have mining node BM connected to base node B and wallet WB
   ✔  When mining node BM mines 10 blocks with min difficulty 1 and max difficulty 1
   ✔  When I wait for wallet WB to have at least 55000000000 uT
   ✘  When I create a burn transaction of 1000000 uT from WB at fee 100
      Step failed:
      Defined: tests/features/Reorgs.feature:43:5
      Matched: integration_tests/tests/steps/wallet_steps.rs:2782:1
      Step panicked. Captured output: Burn transaction has status 0 when we desired 1 (TRANSACTION_STATUS_BROADCAST), 2 (TRANSACTION_STATUS_UNCONFIRMED), or 6 (TRANSACTION_STATUS_CONFIRMED)
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "BM": MinerProcess {
                  name: "BM",
                  base_node_name: "B",
                  wallet_name: "WB",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WB": "B",
          },
          seed_nodes: [
              "SEED_B",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

1 out of 2 runs failed: Scenario: Syncing node while also mining before tip sync: tests/features/Sync.feature:142:5

artifacts/junit-cucumber/cucumber-output-junit.xml [took 26s]
Raw output
Step panicked. Captured output: Service on port 18214 never started
  Scenario Outline: Syncing node while also mining before tip sync
   ✔  Given I have a seed node SEED
   ✔  When I have wallet WALLET1 connected to seed node SEED
   ✔  When I have wallet WALLET2 connected to seed node SEED
   ✔  When I have mining node MINER connected to base node SEED and wallet WALLET1
   ✔  When I have a base node SYNCER connected to all seed nodes
   ✔  When I have mine-before-tip mining node MINER2 connected to base node SYNCER and wallet WALLET2
   ✔  When I stop node SYNCER
   ✔  When mining node MINER mines 101 blocks with min difficulty 1 and max difficulty 9999999999
   ✔  Then node SEED is at height 101
   ✘  When I start base node SYNCER
      Step failed:
      Defined: tests/features/Sync.feature:134:5
      Matched: integration_tests/tests/steps/node_steps.rs:68:1
      Step panicked. Captured output: Service on port 18214 never started
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "MINER": MinerProcess {
                  name: "MINER",
                  base_node_name: "SEED",
                  wallet_name: "WALLET1",
                  mine_until_height: 100000,
                  stealth: false,
              },
              "MINER2": MinerProcess {
                  name: "MINER2",
                  base_node_name: "SYNCER",
                  wallet_name: "WALLET2",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WALLET1": "SEED",
              "WALLET2": "SEED",
          },
          seed_nodes: [
              "SEED",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

19 tests found

There are 19 tests, see "Raw output" for the full list of tests.
Raw output
Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3
Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3
Scenario: Clear out mempool: tests/features/Mempool.feature:46:3
Scenario: Create burn transaction: tests/features/WalletTransactions.feature:412:3
Scenario: Node rolls back reorg on invalid block: tests/features/Reorgs.feature:63:3
Scenario: Simple block sync: tests/features/Sync.feature:26:3
Scenario: Simple propagation: tests/features/Propagation.feature:26:3
Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3
Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3
Scenario: Sync burned output: tests/features/Sync.feature:34:3
Scenario: Syncing node while also mining before tip sync: tests/features/Sync.feature:142:5
Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3
Scenario: Verify UTXO and kernel MMR size in header: tests/features/BlockTemplate.feature:8:1
Scenario: Verify gprc can create block with more than 1 coinbase: tests/features/BlockTemplate.feature:14:5
Scenario: Wallet imports pre_mine UTXO: tests/features/WalletTransactions.feature:170:3
Scenario: Wallet recovery with connected base node staying online: tests/features/WalletRecovery.feature:8:5
Scenario: Wallet sending and receiving one-sided transactions: tests/features/WalletTransactions.feature:8:3
Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3
Scenario: Zero-conf transactions: tests/features/Mempool.feature:124:3