Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add merge mining proxy support for p2pool #6474
feat: add merge mining proxy support for p2pool #6474
Changes from 13 commits
de8f12c
38f4e7e
bfd3cc9
c71912d
1cc4fc3
6f7302e
4aceaa5
bae493b
972c712
4e405d4
ea8835c
67c577b
6b9aba7
62a4869
94736b2
4ef6b26
650f6dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave in the the trace log please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave refactoring this (removing
new_block_template
and usingtari_block
instead) for a next PR when we can do ample tests to verify that the change is good. We had very-hard-to-find sync issues between when the template is requested from the base node and when the block is finally populated by the base node, of state changing midway.