feat: add generic config list type and use throughout all config settings #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a generic config list type for use with config files and applied this to config arrays of type 'Vec<T>'.
Test Results (CI) 3 files 129 suites 39m 16s ⏱️ Results for commit 759bf68. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)36 tests 36 ✅ 15m 15s ⏱️ Results for commit 759bf68. ♻️ This comment has been updated with latest results. |
leet4tari
approved these changes
Sep 17, 2024
SWvheerden
approved these changes
Sep 17, 2024
hansieodendaal
changed the title
ghpbot-tari-project
removed
the
P-reviews_required
hansieodendaal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a generic config list type for use with config files and applied this to config arrays of type 'Vec'. With this PR, all array-type config options can be omitted in the config file and/or passed in via the command line as a config property override with `-p '.
Motivation and Context
Using config options where arrays have been used was not flexible or consistent throughout the config implementation.
How Has This Been Tested?
Added unit tests.
System-level testing.
What process can a PR reviewer use to test or verify this change?
Code review.
System-level testing.
Breaking Changes