feat: broadcast one sided #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests)18 tests +18 18 ✅ +18 4m 39s ⏱️ + 4m 39s For more details on these parsing errors, see this check. Results for commit 8ee00ed. ± Comparison against base commit aca61f3. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 129 suites 43m 4s ⏱️ Results for commit 8ee00ed. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
The one-sided transaction is picked up by the receiver, but statuses mismatch right after the transaction has been sent. I think the statuses should be in sync, so the receiver should start with 'broadcast', maybe even 'pending'.
Sender
2024-09-18 08:40:41 Transaction Broadcast to Mempool - TxId: 8373244691538681433
Notifications───────────────────────────────────────────────────────────────────────────
2024-09-18 09:16:14 Transaction Confirmed - TxId: 8373244691538681433
2024-09-18 09:13:05 Transaction Mined Unconfirmed with 2 confirmations - TxId: 8373244691538681433
2024-09-18 09:13:04 Transaction Mined Unconfirmed with 2 confirmations - TxId: 8373244691538681433
2024-09-18 09:02:25 Transaction Mined Unconfirmed with 1 confirmations - TxId: 8373244691538681433
2024-09-18 09:02:25 Transaction Mined Unconfirmed with 1 confirmations - TxId: 8373244691538681433
2024-09-18 08:45:16 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
2024-09-18 08:45:16 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
2024-09-18 08:43:07 Transaction Broadcast to Mempool - TxId: 8373244691538681433
2024-09-18 08:43:07 Transaction Broadcast to Mempool - TxId: 8373244691538681433
2024-09-18 08:40:41 Transaction Broadcast to Mempool - TxId: 8373244691538681433
Receiver
2024-09-18 08:40:41 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
Notifications──────────────────────────────────────────────────────────────────────────
2024-09-18 09:16:22 Transaction Confirmed - TxId: 8373244691538681433
2024-09-18 09:13:13 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
2024-09-18 09:02:04 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
2024-09-18 08:45:25 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
2024-09-18 08:40:41 Transaction Mined Unconfirmed with 0 confirmations - TxId: 8373244691538681433
There was a problem hiding this comment.
The transaction is not picked up by the receiver wallet, it only receives the initial message from the sender.
Sender
│2024-09-18 12:24:21 Transaction Confirmed - TxId: 3746389574381860457 │
│2024-09-18 12:20:42 Transaction Mined Unconfirmed with 2 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:20:42 Transaction Mined Unconfirmed with 2 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:19:33 Transaction Mined Unconfirmed with 1 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:19:33 Transaction Mined Unconfirmed with 1 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:05:23 Transaction Mined Unconfirmed with 0 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:05:23 Transaction Mined Unconfirmed with 0 confirmations - TxId: 3746389574381860457 │
│2024-09-18 12:01:14 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 12:01:14 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 12:01:14 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 11:56:05 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 11:56:05 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 11:56:05 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 11:52:41 Transaction Broadcast to Mempool - TxId: 3746389574381860457 │
│2024-09-18 11:51:34 Transaction Confirmed - TxId: 8373244691538681433
Receiver
┌Notifications────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│Press C to clear notifications │
│2024-09-18 11:52:41 Transaction Broadcast to Mempool - TxId: 3746389574381860457
SWvheerden
force-pushed
the
sw_broadcast_one_sided
branch
from
0401cce to
01f57dc
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Broadcast one-sided transactions
Motivation and Context
When a wallet sends a 1-sided tx it will now send it across the network to the peer as well. If the peer listens to the it, ti will register the tx immediately and show it to the user.
How Has This Been Tested?
manual