feat!: add input mr into genesis block #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 37m 19s ⏱️ For more details on these failures, see this check. Results for commit ab179b5. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
SWvheerden
reviewed
Oct 4, 2024
hansieodendaal
force-pushed
the
ho_input_mr_into_genesis_block
branch
2 times, most recently
from
2e09aa6 to
0d779ce
Compare
SWvheerden
reviewed
Oct 4, 2024
Added the input merkle root calculation into the genesis block; previously this was just a default hash, which is incorrect. This will enable adding immediate spending of pre-mine outputs in the genesis block.
hansieodendaal
force-pushed
the
ho_input_mr_into_genesis_block
branch
from
fb23f24 to
ab179b5
Compare
SWvheerden
approved these changes
Oct 7, 2024
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 10, 2024
* development: chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617) feat: improve mempool error msg when mempool out of sync (tari-project#6618) feat: exit logic for pre-mine spend (tari-project#6615) chore: new release esme v1.6.0-pre.0 (tari-project#6614) feat: enable identity grpc method by default (tari-project#6613) feat: pre-mine introduce temp ban and add counters (tari-project#6612) chore: changes mainnet default network (tari-project#6610) chore(ci): add riscv64 builds and misc script fixes (tari-project#6611) feat!: esme test pre-mine with immediate spend (tari-project#6609) feat!: add context to ffi callbacks (tari-project#6608) feat: add default exclude dial (tari-project#6607) feat!: add input mr into genesis block (tari-project#6601) feat: update pre_mine specification (tari-project#6606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xxxx_genesis_sanity_check()unit tests.Motivation and Context
The genesis block did not cater for any immediate spend inputs.
How Has This Been Tested?
fn esmeralda_genesis_sanity_check()passes.What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes
BREAKING CHANGE: The genesis block changed; this requires a blockchain restart.