Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add DammSum known-answer test #6638

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

AaronFeickert
Copy link
Collaborator

Description

Adds a known-answer test for the DammSum checksum implementation.

Motivation and Context

The DammSum checksum implementation already had extensive randomized testing, but did not have any known-answer tests. This PR adds one.

How Has This Been Tested?

The new test passes!

What process can a PR reviewer use to test or verify this change?

Ensure the test passes. If you're feeling bored, examine the checksum algorithm to convince yourself of the validity of the test.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

Test Results (CI)

    3 files    129 suites   38m 1s ⏱️
1 338 tests 1 338 ✅ 0 💤 0 ❌
4 012 runs  4 012 ✅ 0 💤 0 ❌

Results for commit a0039b4.

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Oct 17, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   28m 24s ⏱️ + 28m 24s
36 tests +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 
37 runs  +37  36 ✅ +36  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit a0039b4. ± Comparison against base commit c6cbbc1.

@SWvheerden SWvheerden merged commit eb00fb2 into tari-project:development Oct 18, 2024
16 of 17 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Oct 18, 2024
* development:
  test: add merge mining proxy monerod stress test code (tari-project#6639)
  test: add DammSum known-answer test (tari-project#6638)
  feat: add proxy monerod resiliency (tari-project#6637)
@AaronFeickert AaronFeickert deleted the dammsum-kat branch October 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants