Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/24108 integration high charts #31

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

shivamarora1
Copy link
Contributor

@shivamarora1 shivamarora1 commented Feb 13, 2024

Changes for highchart integration.
Screenshot 2024-02-13 at 5 50 35 PM
Screenshot 2024-02-13 at 5 50 47 PM

@shivamarora1 shivamarora1 marked this pull request as ready for review February 13, 2024 12:27
@@ -156,16 +179,11 @@ export default {
</div>`;
return this.createNode("attachment", nodeContent);

case "image":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@su-docker @shivamarora1 Should we keep the image type supported in tarka-chat?

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@akshaymayekar akshaymayekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamarora1 shivamarora1 added the minor Minor version bump label Feb 14, 2024
@shivamarora1 shivamarora1 merged commit 2a1a7d5 into v2 Feb 14, 2024
@shivamarora1 shivamarora1 deleted the feat/24108-integration-high-charts branch February 28, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants