-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for Bevy 0.13 #24
Conversation
Sorry for the delay; I'll get this merged in within |
Sorry for the delay. I reviewed the PR and corrected a few bugs (fixed some of the examples and text inputs), but there's still two issues I'm seeing:
I'm about ready to merge this, but would you mind taking a look at these two points first? |
Thanks for fixes! I'm also seeing the flickering and the issue with font settings. The issue with flicker is already present in the first commit (7b3415b). I'll look into these and set this back to draft in the meantime |
fixed the font settings in 19aaa6d |
I did a bit of digging and found what’s happening with the flickering - see iced-rs/iced#2318 |
Anything else still blocking this PR from being merged? Because if this flicker is the only thing, I'm thinking we should just merge this in now so people can at least be able to use the library instead of not at all. |
Let make a temp fork of iced with disabled cache to workaround this and open an issue here to track it, then I think we can merge. The issue is even worse with a secure input, so I don't think we should merge without it |
switched to cache-less text_input fork (tzemanovic/iced@ac826cf on top of iced v0.12.1) |
Sorry for the delay, but I generally prefer it if the |
This reverts commit b8ef0fb.
For now, I've switched back to using mainline. If users want to use the custom fork, I'm pretty sure they can do that using |
hi, thanks for the crate :)
closes #23
I tried to update for 0.12 earlier and it was tricky as there was no released iced version with a matching winit version. Both iced and bevy have a new release which can be used together again