Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for Bevy 0.13 #24

Merged
merged 10 commits into from
Apr 7, 2024
Merged

update for Bevy 0.13 #24

merged 10 commits into from
Apr 7, 2024

Conversation

tzemanovic
Copy link
Contributor

hi, thanks for the crate :)

closes #23

I tried to update for 0.12 earlier and it was tricky as there was no released iced version with a matching winit version. Both iced and bevy have a new release which can be used together again

Cargo.toml Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@tasgon tasgon mentioned this pull request Feb 23, 2024
@tasgon
Copy link
Owner

tasgon commented Feb 28, 2024

Sorry for the delay; I'll get this merged in within a day or twothis week.

@tasgon
Copy link
Owner

tasgon commented Mar 5, 2024

Sorry for the delay. I reviewed the PR and corrected a few bugs (fixed some of the examples and text inputs), but there's still two issues I'm seeing:

  • I'm noticing flickering whenever I edit the text in the interactive example. This could have something to do with how I fixed it, though.
  • The fonts example doesn't seem to be actually using the custom font. Not just that, but default_text_size is also being ignored. Not sure if this is a bug with this crate or iced, but AFAIK iced's font handling behavior changed drastically in 0.12, so we might be doing something here.

I'm about ready to merge this, but would you mind taking a look at these two points first?

@tzemanovic
Copy link
Contributor Author

Sorry for the delay. I reviewed the PR and corrected a few bugs (fixed some of the examples and text inputs), but there's still two issues I'm seeing:

* I'm noticing flickering whenever I edit the text in the `interactive` example. This could have something to do with how I fixed it, though.

* The `fonts` example doesn't seem to be actually using the custom font. Not just that, but `default_text_size` is also being ignored. Not sure if this is a bug with this crate or iced, but AFAIK iced's font handling behavior changed drastically in 0.12, so we might be doing something here.

I'm about ready to merge this, but would you mind taking a look at these two points first?

Thanks for fixes! I'm also seeing the flickering and the issue with font settings. The issue with flicker is already present in the first commit (7b3415b). I'll look into these and set this back to draft in the meantime

@tzemanovic tzemanovic marked this pull request as draft March 7, 2024 17:52
@tzemanovic
Copy link
Contributor Author

fixed the font settings in 19aaa6d

@tzemanovic
Copy link
Contributor Author

tzemanovic commented Mar 9, 2024

I did a bit of digging and found what’s happening with the flickering - see iced-rs/iced#2318

@tasgon
Copy link
Owner

tasgon commented Mar 20, 2024

Anything else still blocking this PR from being merged? Because if this flicker is the only thing, I'm thinking we should just merge this in now so people can at least be able to use the library instead of not at all.

src/conversions.rs Outdated Show resolved Hide resolved
@tzemanovic
Copy link
Contributor Author

Anything else still blocking this PR from being merged? Because if this flicker is the only thing, I'm thinking we should just merge this in now so people can at least be able to use the library instead of not at all.

Let make a temp fork of iced with disabled cache to workaround this and open an issue here to track it, then I think we can merge. The issue is even worse with a secure input, so I don't think we should merge without it

@tzemanovic
Copy link
Contributor Author

switched to cache-less text_input fork (tzemanovic/iced@ac826cf on top of iced v0.12.1)

@tzemanovic tzemanovic marked this pull request as ready for review March 22, 2024 14:36
@tasgon
Copy link
Owner

tasgon commented Apr 2, 2024

Sorry for the delay, but I generally prefer it if the master branch is publishable to Crates.io, and relying on a fork of iced would make that impossible (unless the fork is also published). If it's only the TextInput component that's causing problems, do you think it would be possible to vendor in the component into bevy_iced?

@tasgon
Copy link
Owner

tasgon commented Apr 7, 2024

For now, I've switched back to using mainline. If users want to use the custom fork, I'm pretty sure they can do that using [patch].

@tasgon tasgon merged commit 87f7eaa into tasgon:master Apr 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Bevy 0.12
3 participants