Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Style guide to Storybook #15

Closed
JiwoonKim opened this issue Dec 13, 2019 · 2 comments
Closed

Change Style guide to Storybook #15

JiwoonKim opened this issue Dec 13, 2019 · 2 comments

Comments

@JiwoonKim
Copy link
Collaborator

Considering maybe changing the style guide for the project from styleguidist to storybook

Style guide Usages:

  • building UI components
  • document usages of components
  • testing examples of data for components

References

@JiwoonKim
Copy link
Collaborator Author

JiwoonKim commented Dec 26, 2019

Since the current 5.2 version of Storybook uses .storybook/ folder for configurations, we are not able to use the storybook.config.js file method which exports a preset.

At the moment, customizing Storybook's webpack setup requires creating its own webpack.config.js file under the .storybook/ folder since Storybook has its own Webpack setup and a dev server. Further customizations can be referred from https://storybook.js.org/docs/configurations/custom-webpack-config/#webpack-customisation-modes/ .


Luckily, Storybook is in the progress of implementing a storybook.config.js file that exports a preset for the upcoming v6.0.0 (storybookjs/storybook#6806)! Once this feature is fully implemented, it will be easier to hook Storybook with neutrino's preset configs (if webpack customization is necessary at all) 🌈 .

@JiwoonKim
Copy link
Collaborator Author

closed by #39 and opened new issue to continue in #55 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant