-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Style guide to Storybook #39
Conversation
import { configure } from '@storybook/react'; | ||
|
||
configure(require.context('../src', true, /\.stories\.js$/), module); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook utilizes configs in .storybook/
folder (see #15 (comment)).
Overall, this config.js
file helps Storybook to work 🌈 .
ℹ️ I've also tried customizing Storybook's webpack config to utilize Neutrino's webpack config, however, had come across some undesirable results.
- complexity in configuring Neutrino's webpack config to match Storybook's
full control mode
which returns a function instead of an object form (https://storybook.js.org/docs/configurations/custom-webpack-config/#webpack-customisation-modes) - when Neutrino's webpack config gets hooked into Storybook's webpack config, storybook UI does not display correctly
Since Storybook works fine even without hooking Neutrino's webpack config (and hooking Neutrino's webpack config would rather produce undesirable consequences), I think it's best we leave Storybook's config as-is.
Maybe if Storybook implements changes to use storybook.config.js
to export a preset, we may be able to consider hooking webpack in the future, if necessary :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Thank you for the explanation, very helpful. I'll try to look into it soon and get back to you.
Since Storybook also has |
Closes Issue #15
change the style guide for the project to
storybook
Applied Changes
styleguide
examples tostorybook
deploy
script to building storybook on github-pages (static mode)styleguidist
from project