fix: modified QueueGetters.getJob and Job.fromId to return undefined

instead of null
taskforcesh · Feb 11, 2020 · ede352b · ede352b
1 parent 65183fc
commit ede352b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/classes/job.ts b/src/classes/job.ts
@@ -135,12 +135,15 @@ export class Job<T = any, R = any> {
     return job;
   }
 
-  static async fromId(queue: QueueBase, jobId: string): Promise<Job | null> {
+  static async fromId(
+    queue: QueueBase,
+    jobId: string,
+  ): Promise<Job | undefined> {
     // jobId can be undefined if moveJob returns undefined
     if (jobId) {
       const client = await queue.client;
       const jobData = await client.hgetall(queue.toKey(jobId));
-      return isEmpty(jobData) ? null : Job.fromJSON(queue, jobData, jobId);
+      return isEmpty(jobData) ? undefined : Job.fromJSON(queue, jobData, jobId);
     }
   }
 

diff --git a/src/classes/queue-getters.ts b/src/classes/queue-getters.ts
@@ -6,7 +6,7 @@ import { Job } from './job';
 import { clientCommandMessageReg } from './worker';
 
 export class QueueGetters extends QueueBase {
-  getJob(jobId: string): Promise<Job | null> {
+  getJob(jobId: string): Promise<Job | undefined> {
     return Job.fromId(this, jobId);
   }