Emit failed and stalled events after moveStalledJobsToWait() #10
Labels
Comments
stansv
changed the title
manast
added a commit
that referenced
this issue
Sep 20, 2019
manast
pushed a commit
that referenced
this issue
Oct 20, 2019
### Bug Fixes * add compilation step before running tests ([64abc13](64abc13)) * add extra client to worker fixes [#34](#34) ([90bd891](90bd891)) * add missing dependency ([b92e330](b92e330)) * check closing after resuming from pause ([7b2cef3](7b2cef3)) * default opts ([333c73b](333c73b)) * do not block if blockTime is zero ([13b2df2](13b2df2)) * do not exec if closing ([b1d1c08](b1d1c08)) * do not trim if maxEvents is undefined ([7edd8f4](7edd8f4)) * emit wait event in add job ([39cba31](39cba31)) * fix a couple of job tests ([e66b97b](e66b97b)) * fix compiling error ([3cf2617](3cf2617)) * fix more tests ([6a07b35](6a07b35)) * fix progress script ([4228e27](4228e27)) * fix retry functionality ([ec41ea4](ec41ea4)) * fix several floating promises ([590a4a9](590a4a9)) * fixed reprocess lua script ([b78296f](b78296f)) * improve concurrency mechanism ([a3f6148](a3f6148)) * improve disconnection for queue events ([56b53a1](56b53a1)) * initialize events comsumption in constructor ([dbb66cd](dbb66cd)) * make ioredis typings a normal dependency ([fb80b90](fb80b90)) * minor fixes ([7791cda](7791cda)) * parse progres and return value in events ([9e43d0e](9e43d0e)) * properly emit event for progress ([3f70175](3f70175)) * reduce drain delay to 5 seconds ([c6cfe7c](c6cfe7c)) * remove buggy close() on redis-connection (fixes 5 failing tests) ([64c2ede](64c2ede)) * remove unused dependencies ([34293c8](34293c8)) * replace init by waitUntilReady ([4336161](4336161)) * reworked initialization of redis clients ([c17d4be](c17d4be)) * several fixes to make the lib work on other ts projects ([3cac1b0](3cac1b0)) * throw error messages instead of codes ([9267541](9267541)) * update tests after merge ([51f75a4](51f75a4)) * wait until ready before trying to get jobs ([f3b768f](f3b768f)) * **connections:** reused connections ([1e808d2](1e808d2)) * waitUntilFinished improvements ([18d4afe](18d4afe)) ### Features * add cleaned event ([c544775](c544775)) * add empty method ([4376112](4376112)) * add retry errors ([f6a7990](f6a7990)) * add script to generate typedocs ([d0a8cb3](d0a8cb3)) * add some new tests for compat class, more minor fixes ([bc0f653](bc0f653)) * add support for adding jobs in bulk ([b62bddc](b62bddc)) * add trimEvents method to queue client ([b7da7c4](b7da7c4)) * automatically trim events ([279bbba](279bbba)) * emit global stalled event fixes [#10](#10) ([241f229](241f229)) * get rid of Job3 in favor of bullmq Job class ([7590cea](7590cea)) * implement close in redis connection fixes [#8](#8) ([6de8b48](6de8b48)) * make delay in backoffs optional ([30d59e5](30d59e5)) * move async initialization to constructors ([3fbacd0](3fbacd0)) * port a lot of functionality from bull 3.x ([ec9f3d2](ec9f3d2)) * port more features from bull 3.x ([75bd261](75bd261)) * ported tests and functionality from bull 3 ([1b6b192](1b6b192)) * **workers:** support for async backoffs ([c555837](c555837)) * remove support of bull3 config format in compat class ([d909486](d909486)) * support global:progress event ([60f4d85](60f4d85)) * trim option to event stream [#21](#21) & fix [#17](#17) ([7eae653](7eae653))
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like with current implementation 'failed' events would be emitted by both worker (on processFn fail) and scheduler when job stalled too much.I see there's no "stalled" event anymore by design, instead moveStalledJobsToWait emits either global "waiting" or "failed".
But I think it would be better to indicate that some job was stalled and that was the reason it is retried or failed.
The text was updated successfully, but these errors were encountered: