-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Queue Name for Logging #140
Labels
Comments
yes, actually I think public is better considering there is no getter for the queue name, no reason to make that property protected/private. |
bobdercole
added a commit
to bobdercole/bullmq
that referenced
this issue
Feb 14, 2020
manast
added a commit
that referenced
this issue
Mar 2, 2020
feat: made queue name publicly readable for #140
🎉 This issue has been resolved in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I like to use queue events for logging. I find it useful to log the queue name with each event.
In Bull v3 we had access to the queue name. However, it was marked protected in v4.
bullmq/src/classes/queue-base.ts
Line 11 in 36726bf
At the moment I am working around the issue by calling
toKey
with an empty string, sincetoKey
happens to contain the queue name.Would you consider making the queue name publicly readable? Or perhaps there is another way to get the name that I'm overlooking?
Thanks!
The text was updated successfully, but these errors were encountered: