Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flows): throw error when queueName contains colon #2719

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix(flows): throw error when queueName contains colon #2719

merged 2 commits into from
Aug 29, 2024

Conversation

roggervalf
Copy link
Collaborator

ref #2718

@roggervalf roggervalf changed the title docs(flows): advertise to not include colon in a custom jobId fix(flows): throw error when queueName contains colon Aug 29, 2024
manast
manast approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roggervalf roggervalf merged commit 9ef97c3 into master Aug 29, 2024
10 checks passed
@roggervalf roggervalf deleted the flows-colon branch August 29, 2024 13:10
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@semantic-release-bot
chore(release): 5.12.12 [skip ci]
7104a8c 
## [5.12.12](v5.12.11...v5.12.12) (2024-08-29)

### Bug Fixes

* **flows:** throw error when queueName contains colon ([#2719](#2719)) fixes [#2718](#2718) ([9ef97c3](9ef97c3))
@croconut croconut mentioned this pull request Sep 3, 2024
Open
@adevinwild adevinwild mentioned this pull request Sep 4, 2024
Closed
@q1blue q1blue mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roggervalf @manast