Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/properly update data #2739

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix/properly update data #2739

merged 2 commits into from
Aug 28, 2024

Conversation

manast
Copy link
Contributor

@manast manast commented Aug 27, 2024 •
edited
Loading

fixes #2731

roggervalf
roggervalf approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@roggervalf roggervalf merged commit 9c4b245 into master Aug 28, 2024
10 checks passed
@roggervalf roggervalf deleted the fix/properly-update-data branch August 28, 2024 04:57
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
@semantic-release-bot
chore(release): 5.12.11 [skip ci]
fea6b1a 
## [5.12.11](v5.12.10...v5.12.11) (2024-08-28)

### Bug Fixes

* **sandboxed:** properly update data on wrapped job ([#2739](#2739)) fixes [#2731](#2731) ([9c4b245](9c4b245))
@chrispaskvan chrispaskvan mentioned this pull request Sep 18, 2024
Closed
@q1blue q1blue mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roggervalf roggervalf roggervalf approved these changes

@fgozdz fgozdz Awaiting requested review from fgozdz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Sandbox .updateData unexpected behavior regarding job data
2 participants
@manast @roggervalf