thumbnail WebP as WebP

Closes: matrix-org#11840 Signed-off-by: Ronny (tastytea) Gutbrod <tastytea@tastytea.de>
tastytea · Mar 18, 2023 · d2f795b · d2f795b
1 parent 3d70cc3
commit d2f795b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/changelog.d/14890.bugfix b/changelog.d/14890.bugfix
@@ -0,0 +1 @@
+Thumbnail WebP images as WebP instead of JPEG, preserving transparency.
diff --git a/synapse/config/repository.py b/synapse/config/repository.py
@@ -47,7 +47,7 @@
 THUMBNAIL_SUPPORTED_MEDIA_FORMAT_MAP = {
     "image/jpeg": "jpeg",
     "image/jpg": "jpeg",
-    "image/webp": "jpeg",
+    "image/webp": "webp",
     # Thumbnails can only be jpeg or png. We choose png thumbnails for gif
     # because it can have transparency.
     "image/gif": "png",
@@ -102,6 +102,10 @@ def parse_thumbnail_requirements(
                 requirement.append(
                     ThumbnailRequirement(width, height, method, "image/png")
                 )
+            elif thumbnail_format == "webp":
+                requirement.append(
+                    ThumbnailRequirement(width, height, method, "image/webp")
+                )
             else:
                 raise Exception(
                     "Unknown thumbnail mapping from %s to %s. This is a Synapse problem, please report!"

diff --git a/synapse/media/thumbnailer.py b/synapse/media/thumbnailer.py
@@ -1,5 +1,5 @@
-# Copyright 2014-2016 OpenMarket Ltd
-# Copyright 2020-2021 The Matrix.org Foundation C.I.C.
+# Copyright 2014-2016,2023 OpenMarket Ltd
+# Copyright 2020-2021,2023 The Matrix.org Foundation C.I.C.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ class ThumbnailError(Exception):
 
 
 class Thumbnailer:
-    FORMATS = {"image/jpeg": "JPEG", "image/png": "PNG"}
+    FORMATS = {"image/jpeg": "JPEG", "image/png": "PNG", "image/webp": "WEBP"}
 
     @staticmethod
     def set_limits(max_image_pixels: int) -> None: