Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

Install PhantomJS 2.0 #19

Merged
merged 1 commit into from
Apr 3, 2015

Conversation

chrislopresto
Copy link
Contributor

Acceptance tests once again pass on PhantomJS 2.0.

Installing PhantomJS 2.0

PhantomJS 2.0 isn't fully out the door. Linux binaries aren't available from their site. Travis is hosting a 2.0 binary they built from source.

Installing on OS X

npm uninstall -g phantomjs
bower install phantomjs

Working Theory

Twitter tests that had previously passed began to fail on PhantomJS 1.9.8 (and 1.9.7 I believe). I saw additional test failures locally on PhantomJS 1.9.7 as well.

My unsubstantiated suspicion is that earlier versions of Phantom were defaulting to an SSL protocol for which Twitter killed support in the wake of POODLE. The problem is that twttr.ready never fires, leading me to believe that the Twitter widgets.js script simply isn't arriving.

PhantomJS Config Differences, 1.9.8 vs 2.0.0

https://gist.github.com/chrislopresto/426d617198c232469418#file-phantomjs_poodling-sh-L27

ember-social › phantomjs -v
1.9.8

ember-social › phantomjs -h
  ...
  --ssl-protocol=<val>                 Sets the SSL protocol (supported protocols: 'SSLv3', 'SSLv2', 'TLSv1' (default), 'any')
  ...

ember-social › phantomjs -v
2.0.0

ember-social › phantomjs -h
  ...
  --ssl-protocol=<val>                 Selects a specific SSL protocol version to offer. Values (case insensitive): TLSv1.2, TLSv1.1, TLSv1.0, TLSv1 (same as v1.0), SSLv3, or ANY. Default is to offer all that Qt thinks are secure (SSLv3 and up). Not all values may be supported, depending on the system OpenSSL library.
  ...

ksin added a commit that referenced this pull request Apr 3, 2015
@ksin ksin merged commit 5fab022 into tatango:master Apr 3, 2015
@ksin
Copy link
Contributor

ksin commented Apr 3, 2015

Thanks @chrislopresto !

@chrislopresto
Copy link
Contributor Author

Good stuff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants