Rewrote existing parser with a new logic to detect tweets #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier parser detected tweets by using RegEx queries and matching the Xpath to the tweet text elements with certain given Xpaths.
However, I discovered that every DIV on the twitter DOM that contains a tweet text has an attribute titled 'data-testid' whose value is always 'tweetText'
Hence, the new method uses the 'querySelectorAll()' method (ref: https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelectorAll) of the DOM in order to select all such DIVs whose data-testid is set to tweetText. This gives an array of all DIVs in the current DOM that contain the spans which contains the tweetText.
This array is discovered in the file parser-v2.js and then sent to the file transform-v2.js and processed there where a for loop runs through all the DIVs and does the processing that was done in transform.js