feat(dialog): implement save API on iOS #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through d249614There are 3 changes which include fs with prerelease, dialog with prerelease, window-state with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Sep 2, 2024
| let destinationFolder = fileManager.urls(for: .documentDirectory, in: .userDomainMask).first! | ||
| let destinationPath = destinationFolder.appendingPathComponent(args.fileName ?? "file") | ||
| if !fileManager.fileExists(atPath: destinationPath.path) { | ||
| // the file contents must be actually provided by the tauri dev after the path is resolved by this API |
There was a problem hiding this comment.
not sure I quite understand this comment or what the logic is trying to do, this comment needs to be improved
There was a problem hiding this comment.
done, hope the implementation makes more sense now
this is due to the Apple API design which does not match other operating systems
amrbashir
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.