fix(shell): fix schema requiring sidecar property even though it is optional

[amrbashir]

No description provided.

[github-actions]

Package Changes Through 8e89fe3

There are 6 changes which include cli with prerelease, deep-link with prerelease, dialog with prerelease, fs with prerelease, shell with prerelease, updater with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
api-example	2.0.0-rc.7	2.0.0-rc.8
cli	2.0.0-rc.1	2.0.0-rc.2
deep-link	2.0.0-rc.6	2.0.0-rc.7
fs	2.0.0-rc.5	2.0.0-rc.6
dialog	2.0.0-rc.7	2.0.0-rc.8
http	2.0.0-rc.5	2.0.0-rc.6
persisted-scope	2.0.0-rc.5	2.0.0-rc.6
shell	2.0.0-rc.3	2.0.0-rc.4
single-instance	2.0.0-rc.4	2.0.0-rc.5
updater	2.0.0-rc.3	2.0.0-rc.4

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[FabianLars]

schema noob here: Is it possible to say that either cmd or sidecar is required? Because now only name is required and that alone doesn't do anything. No biggie if this is not possible but wanted to ask just in case it is.

[amrbashir]

schema noob here: Is it possible to say that either cmd or sidecar is required? Because now only name is required and that alone doesn't do anything. No biggie if this is not possible but wanted to ask just in case it is.

It is probably possible with a custom JsonSchema implementation, I don't think we can do it with the derive macro

[amrbashir]

@FabianLars actually we could just use untagged enum, take a look and see if that's what you meant

[FabianLars]

I don't have access to a computer until tomorrow so I can't check out the generated schema but I assume this is what I meant, or at least close enough x)

[FabianLars]

Okay so I got my hands on my laptop for a minute 😂 It seems to work, cool. vscode just seems to think that args is always required though.

Laptop is gone again so now I really can't test again until tomorrow but with just the args thing I don't think that's a problem

[amrbashir]

alright, fixed that one as well

[lucasfernog]

i love you