Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri) update error handling crate to anyhow+thiserror, close #613 #619

Closed
wants to merge 5 commits into from

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented May 26, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
In this PR, it replaced all functions from error-chain to a more modern error handling crate: anyhow. And most return calls can be even reduced to ? operand. If there's a custom error needed, it used thiserror to define a new error enum type.

@wusyong wusyong requested a review from a team as a code owner May 26, 2020 13:58
@wusyong wusyong requested review from a team May 26, 2020 13:58
@wusyong
Copy link
Member Author

wusyong commented May 26, 2020

Sorry I forgot about other platfroms. Will open again once it's resolved.

@wusyong wusyong closed this May 26, 2020
@tensor-programming
Copy link
Member

@wusyong if you want you can help me work on my PR over at #623. Starting with the bundler and working my way through the libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants