Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix compilation when shell-execute or shell-sidecar #9729

Merged
merged 2 commits into from
May 9, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 9, 2024

closes #9728

regression introduced in: #9706

@amrbashir amrbashir requested a review from a team as a code owner May 9, 2024 20:46
@amrbashir amrbashir merged commit ef35a79 into 1.x May 9, 2024
23 of 24 checks passed
@amrbashir amrbashir deleted the fix/shell-execute-regression branch May 9, 2024 20:56
FabianLars pushed a commit that referenced this pull request Jul 2, 2024
…9729)

* fix(core): fix compilation when `shell-execute` or `shell-sidecar`

regression from: #9706

* change file
lucasfernog added a commit that referenced this pull request Jul 2, 2024
…10174)

* fix(core): fix compilation when `shell-execute` or `shell-sidecar` (#9729)

* fix(core): fix compilation when `shell-execute` or `shell-sidecar`

regression from: #9706

* change file

* lint

---------

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants