Skip to content

Commit

Permalink
fix(web-components): fix icon package pathing for build (carbon-desig…
Browse files Browse the repository at this point in the history
  • Loading branch information
annawen1 authored and tay1orjones committed Oct 2, 2024
1 parent 2f94c56 commit ac3a58e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/publish-web-components-cdn.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ jobs:
node-version: '18.x'
cache: 'yarn'
- name: Install dependencies
run: yarn install
- name: Build Web Components package
run: |
cd packages/web-components
yarn install
yarn build
- name: Check release type
if: contains(github.ref_name, '-rc.')
Expand Down
4 changes: 2 additions & 2 deletions packages/web-components/tasks/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ async function build() {
]);

const iconInput = await globby([
'node_modules/@carbon/icons/lib/**/*.js',
'!**/index.js',
'../../packages/icons/lib/**/*.js',
'!../../packages/icons/lib/index.js',
]);

const entryPoint = {
Expand Down
4 changes: 2 additions & 2 deletions packages/web-components/tools/rollup-plugin-dist-icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ import icon from './svg-result-carbon-icon.js';
* @returns {object} The rollup plugin to transform an `.svg` file to a `lit-html` template.
*/
export default function rollupPluginDistIcons({
include = /@carbon[\\/]icons[\\/]/i,
include = /packages[\\/]icons[\\/]lib[\\/]/i,
exclude,
} = {}) {
const filter = createFilter(include, exclude);
return {
name: 'lit-scss',
name: 'carbon-dist-icons',

/**
* Enqueues the module contents for loading.
Expand Down

0 comments on commit ac3a58e

Please sign in to comment.