Compatibility with Groovy 3 (necessary for Play! compatibility with JDK 14) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2020
asolntsev
approved these changes
Jun 3, 2020
|
Hey @tomparle , thx for this. In the mean time I have fixed the issue with compile error using Eclipse JDT Core > v18, see #2, so I've created my own pull request #5 to bring in your changes to support Groovy v3 on top of that. As I said, I don't seem to need to upgrade to Groovy v3 to make my application work so I've released my compile fix first and then I'll have a look at this Groovy upgrade. |
|
You're welcome ! Thanks for the info, and glad to help if needed ~
…On Sun, Oct 25, 2020 at 2:06 PM Chris Webb ***@***.***> wrote:
Hey @tomparle <https://github.com/tomparle> , thx for this. In the mean
time I have fixed the issue with compile error using Eclipse JDT Core >
v18, see #2 <#2>, so I've
created my own pull request #5
<#5> to bring in your changes
to support Groovy v3 on top of that. As I said
<playframework/play1#1324 (comment)>,
I don't seem to need to upgrade to Groovy v3 to make my application work so
I've released my compile fix first and then I'll have a look at this Groovy
upgrade.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMPMDKUUHDSWOZAN5M52LSMQPEVANCNFSM4NR2Z3LA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code updated to be compatible with Groovy 3, so that it can be used with by Play to be compatible with JDK 14.