feat: capability to send the client response to clipboard #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I will have a look into it! |
tbckr
requested changes
Sep 29, 2023
cli/root_test.go
Outdated
| defer wg.Done() | ||
| var buf bytes.Buffer | ||
| _, err := io.Copy(&buf, reader) | ||
| _ = clipboard.WriteAll(buf.String()) |
There was a problem hiding this comment.
Here we are overriding the values which were set in the root command. Therefore we are not actually testing the functionality.
There was a problem hiding this comment.
Sorry you are right
cli/root_test.go
Outdated
| root.Execute([]string{"--clipboard", prompt}) | ||
| require.Equal(t, 0, mem.code) | ||
| require.NoError(t, writer.Close()) | ||
|
|
There was a problem hiding this comment.
Maybe we could do something like this:
Suggested change
| textInClipboard := clipboard.ReadAll() | |
| require.Equals(t, expected, textInClipboard) |
With this we could remove the go func part, io.Pipe and writer.
tbckr
approved these changes
Sep 30, 2023
|
The error in the CI pipeline is expected. The Github runner does not have a clipping tool installed. I will fix this test error after the merge. |
tbckr
pushed a commit
that referenced
this pull request
Sep 30, 2023
* feat: capability to send the client response to clipboard * feat: capability to send the client response to clipboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incredible tool, thank you for creating it, it has been very useful for me. I Created this simple pr to add the ability to save the client's response to the clipboard, it's not a big change, but it's something useful for me.