-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binary wheel build step #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please mark this as ready for review when it's done |
Notes:
|
Thanks for the PR. It'll be good to finally have wheels, 3 years later. There are a few areas of future work I've noted, otherwise looks good to me (as long as it actually works). If you don't mind me asking, what are you using v8py for? |
tbodt
reviewed
Aug 1, 2020
Open
This is great. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPI expects Linux binaries to be built to the manylinux specification. The build toolchain for V8 uses a new-ish glibc, so this process produces manylinux2014-compatible packages.
I've tested the cibuildwheel build process, but the changes to the Travis build script are speculative based on the manual process I used. With luck opening a PR will fire off a proper test.