Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: deduplicate some work in atomics #2015

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Editorial: deduplicate some work in atomics #2015

merged 2 commits into from
Sep 9, 2020

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented May 26, 2020 •
edited
Loading

Replaces #835. This includes two of the three commits in that PR; the third, 8e56f87, I am not inclined to take.

I'm neutral on the second commit, but included it for completeness.

(I opened a separate PR rather than just updating #835 because I wanted to drop 8e56f87 but didn't want to force-push it away.)

cc @anba @syg @lars-t-hansen

jmdyck
jmdyck reviewed May 26, 2020
View reviewed changes
spec.html Show resolved Hide resolved
syg
syg approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, centralizing the lea in a single place.

spec.html Show resolved Hide resolved
@ljharb ljharb self-assigned this Aug 26, 2020
@ljharb ljharb requested review from michaelficarra and a team August 26, 2020 22:14
@ljharb ljharb assigned bakkot and unassigned ljharb Sep 2, 2020
@bakkot bakkot force-pushed the dedup-atomics-math branch from 1d1fec7 to 3a1b2ec Compare September 4, 2020 04:20
@bakkot
Copy link
Contributor Author

bakkot commented Sep 4, 2020

Rebased. @syg would you take a quick look to make sure I correctly rebased on top of #1908?

ljharb pushed a commit that referenced this pull request Sep 4, 2020
@bakkot @ljharb
Editorial: remove AtomicLoad (#2015)
25333f8
@ljharb ljharb force-pushed the dedup-atomics-math branch from 3a1b2ec to 25333f8 Compare September 4, 2020 05:28
ljharb pushed a commit that referenced this pull request Sep 4, 2020
@bakkot @ljharb
Editorial: remove AtomicLoad (#2015)
ba298e8
@ljharb ljharb force-pushed the dedup-atomics-math branch from 25333f8 to ba298e8 Compare September 4, 2020 06:04
ljharb pushed a commit that referenced this pull request Sep 4, 2020
@bakkot @ljharb
Editorial: remove AtomicLoad (#2015)
87e833e
@ljharb ljharb force-pushed the dedup-atomics-math branch from ba298e8 to 87e833e Compare September 4, 2020 19:51
@bakkot bakkot added the editor call to be discussed in the next editor call label Sep 7, 2020
syg
syg approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for rebasing

@bakkot bakkot removed the editor call to be discussed in the next editor call label Sep 9, 2020
@ljharb ljharb force-pushed the dedup-atomics-math branch from 87e833e to 5a1a2df Compare September 9, 2020 21:00
@ljharb ljharb merged commit 5a1a2df into master Sep 9, 2020
@ljharb ljharb deleted the dedup-atomics-math branch September 9, 2020 21:07
@ljharb ljharb mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdyck jmdyck jmdyck left review comments

@syg syg syg approved these changes

@ljharb ljharb ljharb approved these changes

@michaelficarra michaelficarra Awaiting requested review from michaelficarra

Assignees

@bakkot bakkot

Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakkot @ljharb @syg @jmdyck