Editorial: Relocate the definition of StringIndexOf #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Jun 29, 2020
ljharb
approved these changes
Jun 29, 2020
bakkot
approved these changes
Jul 1, 2020
PR tc39#2009 recently introduced StringIndexOf, locating its definition in a subclause of "10 ECMAScript Language: Source Code". This placement doesn't make much sense, as StringIndexOf isn't particularly related to source code. This commit relocates it to 6.1.4 The String Type.
ljharb
force-pushed
the
relocate_StringIndexOf
branch
from
a36a7e6
to
34d2050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2009 recently introduced StringIndexOf, locating its definition in a subclause of 10 ECMAScript Language: Source Code. This placement doesn't make much sense, as StringIndexOf isn't particularly related to source code.
There are various plausible places where it could go:
This PR picks the first option. (I think there's a nice modularity to defining a String operation close to the definition of the String type.)