Editorial: Remove "message" property from list of Error differences #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Mar 20, 2024
|
@drakedevel i'm happy to take care of the suggestions, but can you please sign the contributor form if you haven't yet? |
bakkot
reviewed
Mar 20, 2024
bakkot
approved these changes
Mar 20, 2024
ljharb
pushed a commit
to drakedevel/ecma262
that referenced
this pull request
Mar 20, 2024
…c39#3292) This language is a holdover from ES3, the "message" property of all Error prototype objects is defined to be the empty string since ES5. Co-authored-by: Andrew Drake <adrake@adrake.org> Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
ljharb
force-pushed
the
error-message-intro
branch
from
55588cc to
21aa00e
Compare
Signed! |
ljharb
pushed a commit
to drakedevel/ecma262
that referenced
this pull request
Mar 21, 2024
…c39#3292) This language is a holdover from ES3, the "message" property of all Error prototype objects is defined to be the empty string since ES5. Co-authored-by: Andrew Drake <adrake@adrake.org> Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
ljharb
force-pushed
the
error-message-intro
branch
from
21aa00e to
2ddd79e
Compare
bakkot
approved these changes
Mar 21, 2024
bakkot
added
the
ready to merge
…c39#3292) This language is a holdover from ES3, the "message" property of all Error prototype objects is defined to be the empty string since ES5. Co-authored-by: Andrew Drake <adrake@adrake.org> Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
ljharb
force-pushed
the
error-message-intro
branch
from
2ddd79e to
3d5a70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1794 (comment) the language about an
implementation-defined "message"property in the NativeError section is an outdated holdover from ES3, since the definition was changed to be the empty string in ES5. The outdated language was subsequently duplicated to the Error section in #2040.Since the message prototype property is defined to be the empty string for all Error types, I thought it would be least confusing to remove it from the "differing only in ..." list entirely.
I am also inclined to update
only in the name used as the constructor name instead of _NativeError_toonly in the constructor namein the Error Objects copy, since that clause isn't specific to NativeError. I can roll that into this PR or open a new one if that sounds good.