Meta: Upgrade ESMeta to v0.4.3 #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Oct 10, 2024
bakkot
approved these changes
Oct 10, 2024
michaelficarra
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the version of ESMeta to v0.4.3 to resolve the issue es-meta/esmeta#258 by this commit es-meta/esmeta@de9ef68.
With this support, the ESMeta type checker can support the
Constructortype as a subtype of theFunctionObjecttype, and we can remove theOrdinaryCreateFromConstructorin theesmeta-ignore.jsonfile.However, because of the precise constructor type, we need to add the
TypedArrayCreateFromConstructoralgorithm in theesmeta-ignore.jsonfile. It happens the current ESMeta type checker does not support type refinement for algorithm invocation. For example, we need to refine the type ofCintoConstructorwhen the return value ofIsConstructor(C)istrue. We are actively working on a more advanced type analysis technique to resolve this problem in a general way. We will update ESMeta with this new system in few weeks.