Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Miscellaneous quick fixes #3454

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Editorial: Miscellaneous quick fixes #3454

merged 5 commits into from
Nov 8, 2024
+7 −7

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Oct 19, 2024

See the commit messages for details.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Nov 7, 2024
jmdyck added 5 commits November 8, 2024 11:10
@jmdyck @ljharb
Editorial: Change "the String value" to "the value" in a Note (tc39#3454
473cae9 
)

... because it's talking about a string literal in *Java*.

See tc39#3310 (comment)
@jmdyck @ljharb
Editorial: Change "Yield" to "GeneratorYield" in two Note-steps (tc39…
d27161d 
…#3454)

(PR tc39#2548 unfolded many invocations of Yield, but didn't change the accompanying Note-steps.)
@jmdyck @ljharb
Editorial: Fix CreateListFromArrayLike preamble (tc39#3454)
e887590 
PR tc39#3409 changed a parameter of CreateListFromArrayLike,
but didn't make the corresponding change to the preamble.
(And PR tc39#3419 failed to fix it.)
@jmdyck @ljharb
Editorial: Fix Promise.try preamble (tc39#3454)
c4dc43c 
(Make it consistent with PR tc39#2592)
@jmdyck @ljharb
Editorial: Fix two simple typos (tc39#3454)
0f2e04e
@ljharb ljharb merged commit 0f2e04e into tc39:main Nov 8, 2024
8 checks passed
@jmdyck jmdyck deleted the quick_fixes_8 branch November 15, 2024 14:06
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
@jmdyck @kimjg1119
Editorial: Change "the String value" to "the value" in a Note (tc39#3454
f1882d0 
)

... because it's talking about a string literal in *Java*.

See tc39#3310 (comment)
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
@jmdyck @kimjg1119
Editorial: Change "Yield" to "GeneratorYield" in two Note-steps (tc39…
416b82f 
…#3454)

(PR tc39#2548 unfolded many invocations of Yield, but didn't change the accompanying Note-steps.)
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
@jmdyck @kimjg1119
Editorial: Fix CreateListFromArrayLike preamble (tc39#3454)
ee11a58 
PR tc39#3409 changed a parameter of CreateListFromArrayLike,
but didn't make the corresponding change to the preamble.
(And PR tc39#3419 failed to fix it.)
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
@jmdyck @kimjg1119
Editorial: Fix Promise.try preamble (tc39#3454)
8ecb0c5 
(Make it consistent with PR tc39#2592)
kimjg1119 pushed a commit to kimjg1119/ecma262 that referenced this pull request Nov 20, 2024
@jmdyck @kimjg1119
Editorial: Fix two simple typos (tc39#3454)
5ba4edd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmdyck @syg @michaelficarra @bakkot @ljharb