Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Move getting the TA type inside the RMW function #3499

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Editorial: Move getting the TA type inside the RMW function #3499

merged 1 commit into from
Nov 26, 2024

Conversation

syg
Copy link
Contributor

@syg syg commented Nov 25, 2024

Fixes #3117

@syg syg requested a review from a team November 25, 2024 23:55
@syg
Copy link
Contributor Author

syg commented Nov 25, 2024

dawg in what way is this not type checking

@bakkot
Copy link
Contributor

bakkot commented Nov 26, 2024

@syg It's fixing type errors, which means esmeta-ignore needs to be updated. These were previously xfail'd. See the log:

To suppress this error message, remove the following names from esmeta-ignore.json:

  • INTRINSICS.Atomics.add
  • INTRINSICS.Atomics.sub

@michaelficarra michaelficarra added editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land. labels Nov 26, 2024
@ljharb ljharb force-pushed the fix-atomics-add-sub branch from 7824894 to 3e6f71c Compare November 26, 2024 19:29
@ljharb ljharb merged commit 3e6f71c into tc39:main Nov 26, 2024
8 checks passed
@kimjg1119 kimjg1119 mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atomics.{add,sub} call TypedArrayElementType before validating the input is actually a TypedArray
4 participants
@syg @bakkot @michaelficarra @ljharb