Normative: add `globalThis` #702

ljharb · 2016-09-29T00:02:22Z

Adds intrinsic %GlobalThisValue%
Sets it in SetRealmGlobalObject
Adds global name globalThis

ljharb · 2016-09-29T00:03:59Z

Note: do not merge until stage 4 - an approved PR is now a pre-stage-4 requirement.

littledan · 2018-03-05T10:47:40Z

For context, the name global has web compatibility issues. @ljharb is working on switching to a new name. This patch will not land in its current state.

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

spec.html

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

spec.html

domenic · 2019-03-07T16:22:56Z

FYI to TC39: there is an interesting question of what globalThis should be for discarded windows. (I.e. those whose parent iframe was .remove()ed, or whose window was .close()ed.) It appears Chrome/Safari/Firefox all continue to return the global object in that case. However, for self/window/frames, Safari returns null instead.

@annevk filed a bug on Safari to align their window/self/frames with Chrome/Firefox, and also with their own globalThis implementation.

So, there is no action here for TC39, but I thought it'd be interesting to know.

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb · 2019-03-09T21:02:29Z

spec.html

@@ -23338,6 +23337,12 @@ <h1>The Global Object</h1>
  <emu-clause id="sec-value-properties-of-the-global-object">
    <h1>Value Properties of the Global Object</h1>

+    <emu-clause id="sec-global-this">
+      <h1>globalThis</h1>
+      <p>The initial value of `globalThis` is the value of the field of (the value of the field of the Realm Record named [[GlobalEnv]]) named [[GlobalThisValue]].


this phrasing is super awkward. Any recommendations of how to do this cleaner without algorithm steps?

Suggested change

<p>The initial value of `globalThis` is the value of the field of (the value of the field of the Realm Record named [[GlobalEnv]]) named [[GlobalThisValue]].

<p>The initial value of the `globalThis` property of the global object of a realm _realm_ is the value of `_realm_.[[GlobalEnv]].[[GlobalThisValue]]`.</p>

That fudges the distinction between a realm and a Realm Record, so you could say ... of a realm represented by the Realm Record _realm_ ..., but I'm doubtful that'd be better.

spec.html

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

spec.html

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

jmdyck

Looks okay to me.

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.

Before this change these getters did not account for Window object's browsing context potentially being null, resulting in a conceptual crash. Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.

ljharb mentioned this pull request Sep 29, 2016

Path to Stage 4! tc39/proposal-global#12

Closed

31 tasks

bterlson added the pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. label Sep 29, 2016

ljharb force-pushed the global branch from d051137 to 23fa426 Compare October 1, 2016 06:43

ljharb force-pushed the global branch from 23fa426 to 300fd51 Compare December 21, 2016 04:28

ljharb self-assigned this Mar 5, 2018

ljharb added the proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. label Mar 21, 2018

ljharb added the normative change Affects behavior required to correctly evaluate some ECMAScript source text label Jul 25, 2018

ljharb force-pushed the global branch from 300fd51 to ad0f815 Compare September 12, 2018 18:59

ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 12, 2018

Normative: add globalThis (tc39#702)

ad0f815

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb changed the title ~~Normative: add global~~ Normative: add globalThis Sep 12, 2018

ljharb requested review from bterlson, bmeck and a team September 12, 2018 18:59

bmeck reviewed Sep 12, 2018

View reviewed changes

spec.html Outdated Show resolved Hide resolved

ljharb force-pushed the global branch from ad0f815 to bd87080 Compare September 12, 2018 19:16

ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 12, 2018

Normative: add globalThis (tc39#702)

bd87080

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

devsnek approved these changes Sep 12, 2018

View reviewed changes

ljharb assigned bterlson and unassigned ljharb Dec 19, 2018

ljharb requested a review from zenparsing December 19, 2018 04:16

ljharb requested review from a team and removed request for bterlson February 28, 2019 20:00

ljharb unassigned bterlson Feb 28, 2019

annevk mentioned this pull request Mar 7, 2019

Make window.window/frames/self deal with no browsing context whatwg/html#4410

Merged

annevk reviewed Mar 7, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

ljharb force-pushed the global branch from bd87080 to 930c246 Compare March 8, 2019 07:22

ljharb added a commit to ljharb/ecma262 that referenced this pull request Mar 8, 2019

Normative: add globalThis (tc39#702)

30b7a4f

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb force-pushed the global branch from a1ce27b to 495a51e Compare March 9, 2019 21:00

ljharb added a commit to ljharb/ecma262 that referenced this pull request Mar 9, 2019

Normative: add globalThis (tc39#702)

b098d68

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb commented Mar 9, 2019

View reviewed changes

jmdyck reviewed Mar 11, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

jmdyck mentioned this pull request Mar 11, 2019

eliminate Lexical Environment? #1473

Closed

ljharb force-pushed the global branch from 495a51e to 109593b Compare March 11, 2019 21:27

ljharb added a commit to ljharb/ecma262 that referenced this pull request Mar 11, 2019

Normative: add globalThis (tc39#702)

3537cb8

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

sjrd mentioned this pull request Jun 4, 2019

Rename js.special.globalThis scala-js/scala-js#3685

Closed

ljharb force-pushed the global branch from 109593b to bfe4500 Compare August 7, 2019 03:38

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 7, 2019

Normative: add globalThis (tc39#702)

fc9f764

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb requested a review from jmdyck September 23, 2019 05:52

zenparsing approved these changes Sep 23, 2019

View reviewed changes

ljharb self-assigned this Sep 23, 2019

jmdyck requested changes Sep 26, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

spec.html Outdated Show resolved Hide resolved

ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 26, 2019

Normative: add globalThis (tc39#702)

98a05ea

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb force-pushed the global branch from bfe4500 to 8a5f018 Compare September 26, 2019 05:58

ljharb requested a review from jmdyck September 26, 2019 05:58

ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Oct 1, 2019

ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 1, 2019

Normative: add globalThis (tc39#702)

a17204e

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb force-pushed the global branch from 8a5f018 to 3c99bcd Compare October 1, 2019 20:45

jmdyck approved these changes Oct 2, 2019

View reviewed changes

Normative: add globalThis (tc39#702)

5b01972

- Adds intrinsic `%GlobalThisValue%` - Sets it in `SetRealmGlobalObject` - Adds global name `globalThis` Per tc39/proposal-global#12

ljharb force-pushed the global branch from 3c99bcd to 5b01972 Compare October 2, 2019 15:13

ljharb merged commit 5b01972 into tc39:master Oct 2, 2019

ljharb deleted the global branch October 2, 2019 15:14

annevk added a commit to whatwg/html that referenced this pull request Oct 2, 2019

Make window.window/frames/self deal with no browsing context

e9f6d61

Language from tc39/ecma262#702. Tests: web-platform-tests/wpt#15720. Helps with #4363.

jaydson mentioned this pull request Oct 2, 2019

Edição 315 - 10/10/2019 braziljs/weekly#289

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative: add `globalThis` #702

Normative: add `globalThis` #702

ljharb commented Sep 29, 2016 •

edited

Loading

ljharb commented Sep 29, 2016

littledan commented Mar 5, 2018

domenic commented Mar 7, 2019 •

edited

Loading

ljharb Mar 9, 2019

jmdyck Mar 9, 2019

jmdyck left a comment

	<p>The initial value of `globalThis` is the value of the field of (the value of the field of the Realm Record named [[GlobalEnv]]) named [[GlobalThisValue]].
	<p>The initial value of the `globalThis` property of the global object of a realm _realm_ is the value of `_realm_.[[GlobalEnv]].[[GlobalThisValue]]`.</p>

Normative: add globalThis #702

Normative: add globalThis #702

Conversation

ljharb commented Sep 29, 2016 • edited Loading

ljharb commented Sep 29, 2016

littledan commented Mar 5, 2018

domenic commented Mar 7, 2019 • edited Loading

ljharb Mar 9, 2019

Choose a reason for hiding this comment

jmdyck Mar 9, 2019

Choose a reason for hiding this comment

jmdyck left a comment

Choose a reason for hiding this comment

Normative: add `globalThis` #702

Normative: add `globalThis` #702

ljharb commented Sep 29, 2016 •

edited

Loading

domenic commented Mar 7, 2019 •

edited

Loading