Normative: Specify String.prototype.replace edge case #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RegExp.prototype[Symbol.replace] as applied to RegExps, if a substitution string is used with a numerical group reference which is out of bounds, the behavior was previously implementation-defined. This patch changes the behavior to not do a replacement. Testing with eshost showed that V8, SpiderMonkey, JSC and ChakraCore all agree on these semantics.
littledan
added
needs test262 tests
|
I guess technically needs-consensus? I can talk about it as part of my item if you like. |
bterlson
added
the
needs consensus
littledan
added a commit
to littledan/test262
that referenced
this pull request
Mar 21, 2017
In tc39/ecma262#853 , standard semantics for this case are proposed. This patch tests the case.
littledan
removed
the
needs test262 tests
|
this reached consensus in March 22nd at the last TC39 meeting. |
leobalter
removed
the
needs consensus
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Mar 27, 2017
In tc39/ecma262#853 , standard semantics for this case are proposed. This patch tests the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RegExp.prototype[Symbol.replace] as applied to RegExps, if a
substitution string is used with a numerical group reference which
is out of bounds, the behavior was previously implementation-defined.
This patch changes the behavior to not do a replacement.
Testing with eshost showed that V8, SpiderMonkey, JSC and ChakraCore
all agree on these semantics.