Normative: Ensure that TypedArray.prototype.fill does one coercion #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, TypedArray.prototype.fill failed to coerce its value argument multiple in the beginning of the definition, instead coercing it when writing into the TypedArray each time. This patch tweaks the definition to perform the coercion once.
littledan
added a commit
to littledan/test262
that referenced
this pull request
Mar 22, 2017
The change is proposed in tc39/ecma262#856 as a fix to tc39/ecma262#855 Here, the ToNumber coercion is done only once, rather than on each iteration. It does not appear that there were previously any tests against repeated coercion for this parameter previously. Tested this test against V8, which failed, as V8 implements the current spec rather than the proposed one.
littledan
added
needs consensus
|
this reached consensus in March 22nd at the last TC39 meeting. |
leobalter
removed
the
needs consensus
|
@bterlson should we have a "has consensus" label for unmerged PRs/issues? |
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Mar 27, 2017
The change is proposed in tc39/ecma262#856 as a fix to tc39/ecma262#855 Here, the ToNumber coercion is done only once, rather than on each iteration. It does not appear that there were previously any tests against repeated coercion for this parameter previously. Tested this test against V8, which failed, as V8 implements the current spec rather than the proposed one.
|
@leobalter good idea; i took the liberty to make one |
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 4, 2017
Update according to new spec change at tc39/ecma262#856 - Call ToNumber only once in BUILTIN - Remove unused FillNumberSlowPath - FillImpl assumes obj_value->IsNumber() is true - Update test Bug:v8:5929,chromium:702902 Change-Id: Ic83e6754d043582955b81c76e68f95e1c6b7e901 Reviewed-on: https://chromium-review.googlesource.com/465646 Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#44373}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TypedArray.prototype.fill failed to coerce its value
argument multiple in the beginning of the definition, instead coercing
it when writing into the TypedArray each time. This patch tweaks
the definition to perform the coercion once.
Fixes #855