Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphics units to NumberFormat #503

Open
devongovett opened this issue Sep 16, 2020 · 5 comments
Open

Add graphics units to NumberFormat #503

devongovett opened this issue Sep 16, 2020 · 5 comments
Labels
c: numbers Component: numbers, currency, units new unit Request for a new unit in Intl.NumberFormat s: comment Status: more info is needed to move forward Small Smaller change solvable in a Pull Request

Comments

@devongovett
Copy link

CLDR includes a category of units for graphics, such as pixels, dots per inch, ems, etc. These are useful in software such as design tools, photo editing tools, etc. to describe objects on screen. It would be useful for Intl.NumberFormat to support these units so applications can properly internationalize these types of values without embedding the translations themselves.

Here are the definitions for the units in CLDR: https://github.com/unicode-org/cldr/blob/5b309e1c53f443f333998cf49cb70614619bb677/common/main/en.xml#L6433-L6472

@sffc sffc added c: numbers Component: numbers, currency, units s: comment Status: more info is needed to move forward Small Smaller change solvable in a Pull Request labels Sep 16, 2020
@longlho
Copy link
Collaborator

longlho commented Dec 11, 2020

@sffc what's the process of proposing more units? We also got request from formatjs/formatjs#2398

@sffc
Copy link
Contributor

sffc commented Dec 11, 2020

If we have enough evidence that this feature request has broad appeal, and that these units are at least as useful as other units that are already in ECMA-402, then this feature request should pass the bar for new ECMA-402 proposals.

Create a proposal repo (might I suggest "proposal-intl-graphics-units") by using template-for-proposals, then add it to the agenda under the projects tab.

As long as all the delegates are onboard with the idea, this proposal will be fairly easy; we can probably get it to Stage 2 in one shot and then Stage 3 soon after.

@zbraniecki
Copy link
Member

@sffc I think @longlho question is broader than "how to add a unit".

I'd like to understand also the reverse of that equation - what would make us reject such request?

Otherwise, I'm not sure what stops the kitchen sink approach of accruing units as people request them.

@sffc
Copy link
Contributor

sffc commented Dec 11, 2020

We should use the same standards for new units as for any other new proposal. We have spent a lot of time drafting #512. The proposal champion just needs to demonstrate that adding new units meets those criteria. If the committee cannot come to consensus that the proposal meets them, then we reject the proposal from Stage 2 advancement.

@zbraniecki
Copy link
Member

I'm convinced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: numbers Component: numbers, currency, units new unit Request for a new unit in Intl.NumberFormat s: comment Status: more info is needed to move forward Small Smaller change solvable in a Pull Request
Projects
None yet
Development

No branches or pull requests

4 participants