Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding guidelines for proposals in CONTRIBUTING.md #512

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Adding guidelines for proposals in CONTRIBUTING.md #512

merged 1 commit into from
Dec 1, 2020

Conversation

sffc
Copy link
Contributor

@sffc sffc commented Nov 9, 2020

Fixes #442

@sffc
Copy link
Contributor Author

sffc commented Nov 16, 2020

Thanks for the reviews!

Does anyone else want to review before I hit the merge button? Unless I hear otherwise, I will hit the merge button on Thursday or Friday.

@zbraniecki zbraniecki mentioned this pull request Dec 1, 2020
Open
@sffc sffc merged commit b45b9f6 into master Dec 1, 2020
@sffc sffc deleted the guidelines branch December 1, 2020 05:41
@sffc sffc mentioned this pull request Dec 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longlho longlho longlho approved these changes

@zbraniecki zbraniecki zbraniecki approved these changes

@littledan littledan Awaiting requested review from littledan

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

@FrankYFTang FrankYFTang Awaiting requested review from FrankYFTang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API surface and scope guidelines
3 participants
@sffc @longlho @zbraniecki