Revert changes from calendar and numberingSystem options #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary revert commit for tc39#175 until a canonicalization for Unicode extensions are added through ResolveLocale. Ref tc39/proposal-intl-locale#96 This commit should be reverted along the proposed solution. Changes are simplified in this single commit to avoid reverting all the 7 original commits from tc39#175.
|
Thanks for preparing this. We achieved consensus last meeting on the fix to tc39/proposal-intl-locale#96, with @jswalden as the champion to fix it. I'd say to set a deadline (say, March 13, which is 1 week before the 10-day TC39 deadline) for the PR, such that we can review and merge it. If we don't have the fix by that time, then we can submit this PR. |
|
I'm closing this down due to #418, there is no need to revert these changes for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary revert commit for #175 until a canonicalization for Unicode extensions are
added through ResolveLocale.
Ref tc39/proposal-intl-locale#96
This commit should be reverted along the proposed solution. Changes are simplified in this single commit to avoid reverting all the 7 original commits from #175.
cc @anba @jswalden @littledan @caiolima.
Considering the changes from #175 are already on the master branch and we need to have the "release candidate cut" set before the next TC39 meeting, this PR will help us setting the ideal path, we can pick one of these:
Unfortunately I don't see a way to push everything (including canonicalization fixes) for the ECMA-402 2020, technically we need to communicate and confirm consensus for the changes in the next TC39 meeting and I'd rather not rush things.
My preference is option 1, but I'd go with number 2 if anyone opposes to it. This PR is to keep both options equally available.