Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Correct Gregorian calendar BC(E) era to signed years less than 1 AD #729

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Normative: Correct Gregorian calendar BC(E) era to signed years less than 1 AD #729

merged 1 commit into from
Feb 1, 2023

Conversation

gibson042
Copy link
Contributor

Fixes #723

@gibson042
Copy link
Contributor Author

test262 PR: tc39/test262#3722

ptomato
ptomato approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that this is correct, and represents existing web reality.

sffc
sffc approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sffc
Copy link
Contributor

sffc commented Dec 8, 2022

TG2 consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-12-08.md#normative-correct-gregorian-calendar-bce-era-to-signed-years-less-than-1-ad-729

@gibson042
Copy link
Contributor Author

This change achieved consensus at the TC39 plenary of 2023-01-31.

@gibson042 gibson042 merged commit 2034315 into tc39:master Feb 1, 2023
@gibson042 gibson042 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@sffc sffc sffc approved these changes

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
normative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong era for ISO year 0 in Gregorian calendar
4 participants
@gibson042 @sffc @ptomato @ryzokuken